Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash in test mode when using deferred SSC with set as default feature #10273

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Crash in test mode when using deferred SSC with set as default feature #10273

wants to merge 1 commit into from
+22 −0

Conversation

amk-stripe
Copy link
Collaborator

Summary

Crash in test mode when using deferred SSC with set as default feature

Motivation

https://jira.corp.stripe.com/browse/MOBILESDK-3049

Testing

  • Added tests
  • Modified tests
  • Manually verified

It doesn't look like we have any deferred intent + customer sessions end to end tests yet, which is what we'd need to properly test this. I added a jira to track adding those tests, but I'd prefer to get this PR in before bug bash if possible!

Screenshots

Before After
before screenshot after screenshot

Changelog

@github-actions GitHub Actions
Copy link
Contributor

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │          compressed          │         uncompressed         
          ├───────────┬───────────┬──────┼───────────┬───────────┬──────
 APK      │ old       │ new       │ diff │ old       │ new       │ diff 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
      dex │     2 MiB │     2 MiB │  0 B │   4.1 MiB │   4.1 MiB │  0 B 
     arsc │     1 MiB │     1 MiB │  0 B │     1 MiB │     1 MiB │  0 B 
 manifest │   2.3 KiB │   2.3 KiB │  0 B │     8 KiB │     8 KiB │  0 B 
      res │ 302.6 KiB │ 302.6 KiB │  0 B │ 456.7 KiB │ 456.7 KiB │  0 B 
   native │   6.2 MiB │   6.2 MiB │  0 B │  15.8 MiB │  15.8 MiB │  0 B 
    asset │   7.3 KiB │   7.3 KiB │  0 B │   7.1 KiB │   7.1 KiB │  0 B 
    other │  95.1 KiB │  95.1 KiB │ -1 B │ 182.2 KiB │ 182.2 KiB │  0 B 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
    total │   9.6 MiB │   9.6 MiB │ -1 B │  21.6 MiB │  21.6 MiB │  0 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 20114 │ 20114 │ 0 (+0 -0) 
   types │  6221 │  6221 │ 0 (+0 -0) 
 classes │  5015 │  5015 │ 0 (+0 -0) 
 methods │ 29998 │ 29998 │ 0 (+0 -0) 
  fields │ 17347 │ 17347 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  164 │  164 │  0   
 entries │ 3643 │ 3643 │  0
APK 
   compressed    │  uncompressed   │                                           
──────────┬──────┼──────────┬──────┤                                           
 size     │ diff │ size     │ diff │ path                                      
──────────┼──────┼──────────┼──────┼───────────────────────────────────────────
 28.9 KiB │ -3 B │   64 KiB │  0 B │ ∆ META-INF/CERT.SF                        
    272 B │ +1 B │    120 B │  0 B │ ∆ META-INF/version-control-info.textproto 
  1.2 KiB │ +1 B │  1.2 KiB │  0 B │ ∆ META-INF/CERT.RSA                       
──────────┼──────┼──────────┼──────┼───────────────────────────────────────────
 30.3 KiB │ -1 B │ 65.3 KiB │  0 B │ (total)

@amk-stripe amk-stripe marked this pull request as ready for review February 26, 2025 22:32
@amk-stripe amk-stripe requested review from a team as code owners February 26, 2025 22:32
samer-stripe
samer-stripe approved these changes Feb 27, 2025
View reviewed changes
Copy link
Collaborator

@samer-stripe samer-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be fine for now! Let's add those tests before private beta if possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samer-stripe samer-stripe samer-stripe approved these changes

Assignees
No one assigned
Labels
default-pms
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amk-stripe @samer-stripe